cluster-api-provider-gcp icon indicating copy to clipboard operation
cluster-api-provider-gcp copied to clipboard

Add additional disk types

Open barbacbd opened this issue 1 year ago • 3 comments
trafficstars

What type of PR is this?

/kind api-change

What this PR does / why we need it: There are missing disk types that are used by downstream services. This PR adds the pd-balanced and hyperdisk-balanced disk types so that others can create machines with these disk types.

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • [x] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests

Release note:

Add the ability to use the pd-balanced and hyperdisk-balanced for the root device type and the addition disks.

barbacbd avatar Jul 01 '24 13:07 barbacbd

Hi @barbacbd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 01 '24 13:07 k8s-ci-robot

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
Latest commit 16c115db557803e2e253b0031590382450de6056
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/66c5fb64e439b400083ee254
Deploy Preview https://deploy-preview-1278--kubernetes-sigs-cluster-api-gcp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 01 '24 13:07 netlify[bot]

/ok-to-test

JoelSpeed avatar Jul 09 '24 06:07 JoelSpeed

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 09 '24 09:07 k8s-ci-robot

LGTM so far.

@barbacbd would you be also able to update the experimental MachinePool to export/support this new disk type? Thanks.

https://github.com/kubernetes-sigs/cluster-api-provider-gcp/blob/e6db2b72de1e436da4b14fd3fd1f97ea92de1395/exp/api/v1beta1/gcpmanagedmachinepool_types.go#L32-L42

Other than that I think I'm happy with it and we can move this forward, adding the validation breaking change later down the line.

damdo avatar Aug 21 '24 14:08 damdo

@cpanato happy to remove the hold and get this merged?

damdo avatar Aug 26 '24 15:08 damdo