cluster-api-provider-gcp
cluster-api-provider-gcp copied to clipboard
Use SetLabels() to set ForwardingRules labels
What type of PR is this? /kind bug
What this PR does / why we need it:
The ForwardingRules resource requires that the SetLabels() method be used to add the labels after the resource has been created. This resource is different than, for example, Instances or Disks. See Issue #1276 for more information.
Which issue(s) this PR fixes Fixes #1276
Special notes for your reviewer:
This is the comment for ForwardingRules in https://github.com/googleapis/google-api-go-client/blame/main/compute/v1/compute-gen.go
// Labels: Labels for this resource. These can only be added or modified
// by the setLabels method.
Labels map[string]string `json:"labels,omitempty"
TODOs:
- [x] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
Release note:
"NONE"
Hi @bfournie. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
| Name | Link |
|---|---|
| Latest commit | e9eda6e401e8ebefdb4d05ff8d372a3d6ff8ab20 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/6696dec96d45d2000883b03e |
| Deploy Preview | https://deploy-preview-1277--kubernetes-sigs-cluster-api-gcp.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bfournie, richardcase
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [richardcase]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment