cluster-api-provider-gcp
cluster-api-provider-gcp copied to clipboard
kubernetes-sigs
Add option to create an InstanceGroup to be used for bootstrap instances
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add a new configuration field to specify that an InstanceGroup should be created for a bootstrap instance. When configured, the InstanceGroup will be created in the first zone and if a bootstrap Instance is created it will be added to this InstanceGroup.
Which issue(s) this PR fixes *(optional, in `fixes #
TODOs:
- [x] squashed commits
- [ ] includes documentation
- [x] adds unit tests
Release note:
Added a new field `CreateBootstrapInstanceGroup` to the `LoadBalancer` struct which configures the Internal LoadBalancer. By default, this field will not be set. When set to 'true' an InstanceGroup will be created named <cluster-id>-bootstrap. If a bootstrap Instance is created it will be added to this InstanceGroup.
Hi @bfournie. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bfournie Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
| Name | Link |
|---|---|
| Latest commit | 34393f4136c994dcf4044870bf9bdafc82297951 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/66aa70ca01b40e0008300c18 |
| Deploy Preview | https://deploy-preview-1266--kubernetes-sigs-cluster-api-gcp.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
API diff changes are in the non-API packages so:
/override pull-cluster-api-provider-gcp-apidiff
@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-gcp-apidiff
In response to this:
API diff changes are in the non-API packages so:
/override pull-cluster-api-provider-gcp-apidiff
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-provider-gcp-verify | 34393f4136c994dcf4044870bf9bdafc82297951 | link | true | /test pull-cluster-api-provider-gcp-verify |
| pull-cluster-api-provider-gcp-apidiff | 34393f4136c994dcf4044870bf9bdafc82297951 | link | false | /test pull-cluster-api-provider-gcp-apidiff |
| pull-cluster-api-provider-gcp-e2e-test | 34393f4136c994dcf4044870bf9bdafc82297951 | link | true | /test pull-cluster-api-provider-gcp-e2e-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/close Closing this as we have solved the issue using a different implementation in cloud-provider-gcp.
@bfournie: Closed this PR.
In response to this:
/close Closing this as we have solved the issue using a different implementation in cloud-provider-gcp.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.