cluster-api-provider-azure icon indicating copy to clipboard operation
cluster-api-provider-azure copied to clipboard

Proposal: publish ref images to Compute Gallery

Open mboersma opened this issue 2 years ago • 4 comments

What type of PR is this?

/kind design

What this PR does / why we need it:

Adds a proposal to make publishing CAPZ reference images to Azure Compute Gallery the default.

Which issue(s) this PR fixes:

Refs #2294 Fixes #4163

Special notes for your reviewer:

TODOs:

  • [x] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests

Release note:

Proposal: publish ref images to Compute Gallery

mboersma avatar Mar 29 '23 16:03 mboersma

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Mar 29 '23 16:03 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 29 '23 16:03 k8s-ci-robot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c125458) 51.64% compared to head (17794a6) 51.64%. Report is 1155 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3370   +/-   ##
=======================================
  Coverage   51.64%   51.64%           
=======================================
  Files         182      182           
  Lines       18066    18066           
=======================================
  Hits         9331     9331           
  Misses       8208     8208           
  Partials      527      527           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 10 '23 22:04 codecov-commenter

/milestone next

I've made great progress locally on prototyping this, but it's not going to come together in time for the v1.12 release this week.

mboersma avatar Nov 13 '23 18:11 mboersma

/close

I'm closing this for now to avoid distraction. It's backed up behind a couple other items:

  • ~~Remove go-dev container dependency~~
  • Move all pipelines to Managed ID
  • Maybe move pipelines from ADO to GH Actions

mboersma avatar Apr 25 '24 19:04 mboersma

@mboersma: Closed this PR.

In response to this:

/close

I'm closing this for now to avoid distraction. It's backed up behind a couple other items:

  • ~~Remove go-dev container dependency~~
  • Move all pipelines to Managed ID
  • Maybe move pipelines from ADO to GH Actions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 25 '24 19:04 k8s-ci-robot