cluster-api-provider-azure
cluster-api-provider-azure copied to clipboard
kubernetes-sigs
update the node labels for existing AKS nodepools
What type of PR is this? /kind bug
What this PR does / why we need it:
AKS allows updating the node labels for its nodepools, this PR fixes the normalized diff for agentpool of AKS to include the nodelabels.
TODOs:
- [ ] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
Release note:
fix the bug that doesn't allow updating labels on existing nodepools in AKS
Linter is unhappy https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/2559/pull-cluster-api-provider-azure-test/1559188688703852544
You might need to rebase since #2529 merged and changed some import names
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jackfrancis
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jackfrancis]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.
In response to this:
/cherry-pick release-1.4
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jackfrancis: new pull request created: #2569
In response to this:
/cherry-pick release-1.4
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.