cluster-api-provider-aws
cluster-api-provider-aws copied to clipboard
kubernetes-sigs
:sparkles: Initial dedicated hosts implementation
/kind feature
What this PR does / why we need it:
Enable machines to be provisioned on to dedicated hosts.
Special notes for your reviewer: Resumes work started in cluster-api-provider-aws#5504.
Checklist:
- [x] squashed commits
- [ ] includes documentation
- [x] includes emoji in title
- [x] adds unit tests
- [x] adds or updates e2e tests
Release note:
Adds the capability of provisioning machines on to dedicated hosts.
LGTM label has been added.
@mtulio: The following commands are available to trigger required jobs:
/test pull-cluster-api-provider-aws-build
/test pull-cluster-api-provider-aws-build-docker
/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-test
/test pull-cluster-api-provider-aws-verify
The following commands are available to trigger optional jobs:
/test pull-cluster-api-provider-aws-apidiff-main
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc
/test pull-cluster-api-provider-aws-e2e-eks-testing
Use /test all to run the following jobs that were automatically triggered:
pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-build-docker
pull-cluster-api-provider-aws-e2e-blocking
pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify
In response to this:
/test ?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
I manually canceled the e2e I triggered as e2e is still under investigation!
/hold
placing hold while I look in to related boskos changes. i'm noticing that dedicated hosts aren't being torn down. I think it's because they still have an instance on them when the defer is called that releases the host.
LGTM label has been added.
changes implemented due to underlying function signature changes. placing hold while testing.
@richardcase: The following commands are available to trigger required jobs:
/test pull-cluster-api-provider-aws-build
/test pull-cluster-api-provider-aws-build-docker
/test pull-cluster-api-provider-aws-e2e-blocking
/test pull-cluster-api-provider-aws-test
/test pull-cluster-api-provider-aws-verify
The following commands are available to trigger optional jobs:
/test pull-cluster-api-provider-aws-apidiff-main
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-eks-gc
/test pull-cluster-api-provider-aws-e2e-eks-testing
Use /test all to run the following jobs that were automatically triggered:
pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-build-docker
pull-cluster-api-provider-aws-e2e-blocking
pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-verify
In response to this:
/test ?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/test pull-cluster-api-provider-aws-e2e-eks /test pull-cluster-api-provider-aws-e2e
Looks good from my side, however, until the aws-janitor change merges lets hold this:
/hold
Also lets check a larger set of e2e's
@rvanderp3 - looks like we will need to initially have the e2e test for the dedicated hosts disabled. I'll message you to discuss.
@rvanderp3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-provider-aws-e2e | c2cee8322f0a61e702229c0abce12c13bc4808d9 | link | false | /test pull-cluster-api-provider-aws-e2e |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
LGTM label has been added.