cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Migrate network code to AWS SDK v2

Open nrb opened this issue 8 months ago • 2 comments
trafficstars

Update calls in the following packages and files. Note that this is not necessarily an exhaustive list.

./pkg/cloud/scope/network.go ./pkg/cloud/services/network ./pkg/cloud/services/network/network.go ./pkg/cloud/services/mock_services/network_interface_mock.go

nrb avatar Mar 17 '25 21:03 nrb

See examples on how to migrate here: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/5389

damdo avatar May 14 '25 09:05 damdo

/assign

sowjanyadreddy avatar May 22 '25 16:05 sowjanyadreddy

Hey @sowjanyadreddy thank you for stepping up and helping us with the AWS SDK v2 migration efforts for network code. I was wondering if you had a branch or draft PR we can start to have a look at for an early review. We are looking at moving ahead as quickly as possible with the migrations as they are a blocker for the next CAPA release.

Thanks!

damdo avatar Jul 03 '25 08:07 damdo

Hey damdo, Yes I have 8 files out of the 12 migrated in the network . Will send in a draft MR once I am done with the last 4.

Thanks, Sowjanya

On Thu, Jul 3, 2025 at 1:14 AM Damiano Donati @.***> wrote:

damdo left a comment (kubernetes-sigs/cluster-api-provider-aws#5409) https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/5409#issuecomment-3031319067

Hey @sowjanyadreddy https://github.com/sowjanyadreddy thank you for stepping up and helping us with the AWS SDK v2 migration efforts for network code. I was wondering if you had a branch or draft PR we can start to have a look at for an early review. We are looking at moving ahead as quickly as possible with the migrations as they are a blocker for the next CAPA release.

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/5409#issuecomment-3031319067, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZLBHAKIJAZI33AYLOBWJT3GTQ5LAVCNFSM6AAAAABZGRSCZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMZRGMYTSMBWG4 . You are receiving this because you were mentioned.Message ID: @.*** com>

sowjanyadreddy avatar Jul 04 '25 15:07 sowjanyadreddy

Awesome! Thanks @sowjanyadreddy :)

damdo avatar Jul 04 '25 15:07 damdo

In my code review with @richardcase earlier today we realized that https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/5521 addresses the same changes. So resolving this issue.

sowjanyadreddy avatar Jul 24 '25 16:07 sowjanyadreddy

@sowjanyadreddy - i update the description for #5521 to say that it closes this issue. When the PR merges it will close this.

richardcase avatar Jul 24 '25 16:07 richardcase

It looks like when https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/5521 the GH automation didn't close this issue for some reason. Closing it manually.

damdo avatar Jul 29 '25 15:07 damdo