cluster-api-provider-aws
cluster-api-provider-aws copied to clipboard
kubernetes-sigs
Should InternalDNS names be lower-cased
/kind bug
What steps did you take and what happened: [A clear and concise description of what the bug is.] When using custom DHCP options for a VPC, with a custom hostname that contains capital letters, the Machine status will report the InternalDNS name using both the AWS and custom hostnames for the Machine.
The custom hostname is currently reported cased exactly as it is in the AWS DHCP options, however, if you are using the AWS EC2 metadata service to pull the hostname, and using that to set the hostname of your nodes using the --hostname-override flag, then while you are passing that value through, kubelet lower cases the string since Kube object names must be lower cased.
This creates an inconsistency between the node name being lower case and the Machine status showing a mixed case value.
What did you expect to happen:
DNS names are not case sensitive anyway, but I wondered, should CAPA be lower-casing InternalDNS names to be consistent?
Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]
This may well be a won't fix, but I wanted to see what others thought to the idea of blanket lower casing DNS names.
I've looked at how other providers might do this (Azure, GCP, vSphere), but, for them, the way the names and addresses come across is all sourced from Kube naming anyway, so there cannot be an discrepancy.
Environment:
- Cluster-api-provider-aws version:
- Kubernetes version: (use
kubectl version): - OS (e.g. from
/etc/os-release):
This issue is currently awaiting triage.
If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
I think this causes issues downstream of CAPA, so that even if our systems are working, anything else that relies on hostnames (for example, certificates) might fail if the casing aren't consistent.
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle rotten - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Reopen this issue with
/reopen - Mark this issue as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closedYou can:
- Reopen this issue with
/reopen- Mark this issue as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.