🐛 ROSA: fix ROSAMachinePool changes detection logic

[muraee]

trafficstars

What type of PR is this?

/kind bug

What this PR does / why we need it: Fix the issue where the ROSAMachinePool controller falsely detects an update and keeps sending patch request to the OCM backend.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

• [ ] squashed commits
• [ ] includes documentation
• [ ] includes emojis
• [ ] adds unit tests
• [ ] adds or updates e2e tests

Release note:

Fix ROSAMachinePool changes detection logic

[muraee]

/area provider/rosa

[enxebre]

/lgtm

[enxebre]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~exp/controllers/OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[muraee]

/cherry-pick release-2.5

[k8s-infra-cherrypick-robot]

@muraee: new pull request created: #5025

In response to this:

/cherry-pick release-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.