🐛 Remove Old Mapped ARNs

[wcrum]

trafficstars

What type of PR is this? Bug fix to reference #4740.

/kind bug

What this PR does / why we need it: This PR fixes the issue where old ARNs are not removed within kube-system/aws-auth. We need this for security purposes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #4740.

Special notes for your reviewer:

Checklist:

• [x] squashed commits
• [ ] includes documentation
• [x] includes emojis
• [x] adds unit tests
• [ ] adds or updates e2e tests

Release note:

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign ankitasw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @wcrum. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nrb]

@wcrum Thanks for your PR and your patience.

I think this is a reasonable change. The only thing I think is missing is a test case that demonstrates the desired behavior from the issue; that is, having existing users and updating to remove one (or more).

[damdo]

@wcrum would you be able to add such test? Thanks!

[wcrum]

Added additional tests to MapUsers to verify expected, existing and additional mappings.

[k8s-ci-robot]

@wcrum: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-aws-apidiff-main	09954cff274936fce6e6b959dc8f093184820748	link	false	/test pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-test	09954cff274936fce6e6b959dc8f093184820748	link	true	/test pull-cluster-api-provider-aws-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dims]

@wcrum are the failures in the pull-cluster-api-provider-aws-test related to your changes?

[wcrum]

Failure https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/4919/pull-cluster-api-provider-aws-apidiff-main/1803839875892383744 is related to required changes to the CAPA API Schema as it introduces new functions. Other one I'm not too sure.