cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

:sparkles: Add EKS Pod Identities to AWSManagedControlPlane

Open stefanmcshane opened this issue 1 year ago • 13 comments
trafficstars

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support using AWS EKS Pod Identity Associations for mapping pods to IAM roles without needing OIDC or IRSA

https://docs.aws.amazon.com/eks/latest/userguide/pod-identities.html

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Relates: #4747

Special notes for your reviewer:

Docs available here, for a brief overview on setup

Checklist:

  • [ ] squashed commits
  • [x] includes documentation
  • [ ] includes emojis
  • [x] adds unit tests
  • [ ] adds or updates e2e tests

Release note:

Support mapping kubernetes service account to IAM role using EKS Pod Identity Associations

stefanmcshane avatar Apr 03 '24 22:04 stefanmcshane

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 03 '24 22:04 k8s-ci-robot

Hi @stefanmcshane. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 03 '24 22:04 k8s-ci-robot

/retest

stefanmcshane avatar Apr 05 '24 15:04 stefanmcshane

/retest-required

stefanmcshane avatar Apr 05 '24 16:04 stefanmcshane

Split out the AWS updates to reduce the size of this PR #4916

stefanmcshane avatar Apr 09 '24 20:04 stefanmcshane

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 03 '24 15:06 k8s-ci-robot

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Jun 05 '24 21:06 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 30 '24 01:07 k8s-ci-robot