:sparkles: Add support to specify PartitionNumber of placement group

[chiragkyal]

trafficstars

What type of PR is this? /kind feature

What this PR does / why we need it:

Adds support for users to specify the partition number (PartitionNumber) of a placement group, identified by PlacementGroupName while creating instances.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/4870

Special notes for your reviewer:

Checklist:

• [x] squashed commits
• [ ] includes documentation
• [x] includes emojis
• [x] adds unit tests
• [ ] adds or updates e2e tests

Release note:

Add support to specify PartitionNumber of placement group in instances.

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: chiragkyal / name: Chirag Kyal (7e79b8b162fbb773e3d9f15a6d37d2ffb2c1333c)

[k8s-ci-robot]

Welcome @chiragkyal!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @chiragkyal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chiragkyal]

/assign @Ankitasw

[nrb]

/lgtm

[damdo]

/test pull-cluster-api-provider-aws-e2e /test pull-cluster-api-provider-aws-e2e-eks

[chiragkyal]

/test pull-cluster-api-provider-aws-e2e

[damdo]

/test pull-cluster-api-provider-aws-e2e

[chiragkyal]

Is this related to the PR changes? I'm not quite sure.

Summarizing 1 Failure:
  [FAIL] [unmanaged] [Cluster API Framework] Clusterctl Upgrade Spec [from latest v1beta1 release to v1beta2] [AfterEach] Should create a management cluster and then upgrade all the providers
  /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/cluster_helpers.go:176

[damdo]

Looks like a flake timeout to me, hence the retest. Let's see.

[chiragkyal]

All green :tada: /cc @vincepri @Ankitasw

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment