cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Potential race when AWSCluster/AWSMachine reconciler exits before completion without an error

Open mdbooth opened this issue 1 year ago • 3 comments
trafficstars

/kind bug

This is a real bug in CAPO which we have been hitting regularly in CI: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/1954

The commit which added the offending predicates in CAPO noted that they were copying a pattern from CAPA, and you also still have them.

It may not currently be a real bug in CAPA, but it's a surprising pattern which violates the principle of least astonishment, so it may turn into a real bug in the future.

mdbooth avatar Mar 18 '24 13:03 mdbooth