cluster-api-provider-aws
cluster-api-provider-aws copied to clipboard
🐛 ROSA: fix auto scale and multi zone compute nodes
What type of PR is this? /kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist:
- [ ] squashed commits
- [ ] includes documentation
- [ ] includes emojis
- [ ] adds unit tests
- [ ] adds or updates e2e tests
Release note:
None
Hi @serngawy. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/cc @vincepri
/hold
@muraee why holding the PR? If waiting for another PR to get mereg first, please mentioned the other PR here
/unhold
/lgtm
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vincepri
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~config/crd/bases/OWNERS~~ [vincepri]
- ~~controlplane/rosa/OWNERS~~ [vincepri]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/cherry-pick release-2.4
@damdo: new pull request created: #4914
In response to this:
/cherry-pick release-2.4
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.