cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Support AWS Placement Group Partition Number

Open chiragkyal opened this issue 1 year ago • 1 comments
trafficstars

/kind feature

Describe the solution you'd like After Add support to specify PlacementGroup Name in instances, users can specify pre-created placement group name when running instances, using PlacementGroupName field.

Given that Placement Groups have different placement strategies, Partition strategy allows more precise allocation with a specified Partition Number at the instance level to achieve highest level of availability.

Following that, it is requested to have the ability to specify the PartitionNumber along with PlacementGroupName while creating instances because instances in one partition do not share the underlying hardware with groups of instances in different partitions.

Anything else you would like to add: Documentations

  • https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/placement-groups.html
  • https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_Placement.html

API Proposal api/v1beta2/types.go

type Instance struct {
        ...
        ...
        // PlacementGroupName specifies the name of the placement group in which to launch the instance.
	// +optional
	PlacementGroupName string `json:"placementGroupName,omitempty"`
	
	// PartitionNumber is the partition number within the placement group in which to launch the instance.
	// +kubebuilder:validation:Minimum:=1
	// +kubebuilder:validation:Maximum:=7
	// +optional
	PartitionNumber int64 `json:"partitionNumber,omitempty"`
	...
	...
}

chiragkyal avatar Mar 15 '24 08:03 chiragkyal

This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 15 '24 08:03 k8s-ci-robot

Note: As per https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4883#discussion_r1537682840, the new field name would be PlacementGroupPartition instead of PartitionNumber.

chiragkyal avatar Apr 08 '24 10:04 chiragkyal