cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Graduate the garbage Collection feature

Open richardcase opened this issue 2 years ago • 15 comments
trafficstars

/kind feature

Describe the solution you'd like We introduced GC in v1.5.0 in Aug 2022. I propose that we graduate this feature and enable it by default.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

richardcase avatar Jul 13 '23 14:07 richardcase

/assign

richardcase avatar Jul 13 '23 14:07 richardcase

/milestone v2.3.0

richardcase avatar Jul 13 '23 14:07 richardcase

/triage accepted

richardcase avatar Jul 19 '23 08:07 richardcase

/priority important-soon

richardcase avatar Jul 19 '23 08:07 richardcase

@richardcase do we have a task list to track what all fixes should go as part of this?

Ankitasw avatar Sep 05 '23 06:09 Ankitasw

@Ankitasw I think the remaining tasks are:

  1. Add validation for GC config (https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4485)
  2. Add awscli support for GC configuration.
  3. Update the docs.

Tell me if I missed something.

Fedosin avatar Sep 07 '23 17:09 Fedosin

/milestone v2.4.0

richardcase avatar Nov 16 '23 16:11 richardcase

@Ankitasw I think the remaining tasks are:

Add validation for GC config (https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4485) Add awscli support for GC configuration. Update the docs. Tell me if I missed something.

@Fedosin would you be able to proceed with these tasks?

Ankitasw avatar Jan 11 '24 08:01 Ankitasw

/unassign

richardcase avatar Jan 19 '24 08:01 richardcase

/help

richardcase avatar Jan 19 '24 08:01 richardcase

@richardcase: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 19 '24 08:01 k8s-ci-robot

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Apr 22 '24 15:04 k8s-triage-robot

/triage accepted /priority important-soon

richardcase avatar Apr 22 '24 15:04 richardcase

/milestone v2.5.0

richardcase avatar Apr 22 '24 15:04 richardcase

/assign /lifecycle active

richardcase avatar Apr 26 '24 14:04 richardcase

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Jul 25 '24 14:07 k8s-triage-robot

/triage accepted

richardcase avatar Jul 29 '24 09:07 richardcase