cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Publish clusteraswadm as clusterctl plugin

Open richardcase opened this issue 2 years ago • 9 comments
trafficstars

/kind feature /help /milestone v2.2.0

Describe the solution you'd like With a recent change in CAPI (https://github.com/kubernetes-sigs/cluster-api/pull/8957) it's possible to create plugins for clusterctl (like you can do with kubectl).

We should publish clusterawsadm so it can be used as an plubin like this:

clusterctl aws bootstrap iam create-cloudformation-stack

Anything else you would like to add:

This means we need to publish a binary called clusterctl-aws

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

richardcase avatar Jul 11 '23 10:07 richardcase

@richardcase: The provided milestone is not valid for this repository. Milestones in this repository: [v2.3.0, v2.x]

Use /milestone clear to clear the milestone.

In response to this:

/kind feature /help /milestone v2.2.0

Describe the solution you'd like With a recent change in CAPI (https://github.com/kubernetes-sigs/cluster-api/pull/8957) it's possible to create plugins for clusterctl (like you can do with kubectl).

We should publish clusterawsadm so it can be used as an plubin like this:

clusterctl aws bootstrap iam create-cloudformation-stack

Anything else you would like to add:

This means we need to publish a binary called clusterctl-aws

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 11 '23 10:07 k8s-ci-robot

@richardcase: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/kind feature /help /milestone v2.2.0

Describe the solution you'd like With a recent change in CAPI (https://github.com/kubernetes-sigs/cluster-api/pull/8957) it's possible to create plugins for clusterctl (like you can do with kubectl).

We should publish clusterawsadm so it can be used as an plubin like this:

clusterctl aws bootstrap iam create-cloudformation-stack

Anything else you would like to add:

This means we need to publish a binary called clusterctl-aws

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 11 '23 10:07 k8s-ci-robot

/triage accepted /priority important-soon

richardcase avatar Jul 11 '23 10:07 richardcase

This means we need to publish a binary called clusterctl-aws

@richardcase Can we consider renaming clusterawsadm? or publish two similar binaries? happy to help with this.

Which component is responsible for publishing the release artifacts?

a-hilaly avatar Jul 21 '23 13:07 a-hilaly

@richardcase do you know where do we publish this artifact so that it can be used as plugin in clusterctl.

Ankitasw avatar Aug 21 '23 14:08 Ankitasw

We can publish it on our GitHub release, and it can be downloaded and placed in a users' PATH.

richardcase avatar Aug 31 '23 05:08 richardcase

@richardcase we are already publishing clusterawsadm in our release binary, how do we publish it so that it can be used as plugin?

Ankitasw avatar Sep 05 '23 07:09 Ankitasw

I can attempt working on this one.

The initial idea I'm having in my mind is to rename cmd/clusterawsadm to cmd/clusterctl-aws and then adjust the imports and Makefile as per that.

A simpler approach would be to keep using clusterawsadm name and modify the binary name at build time using -o clusterctl-aws.

Please let me know if I should go ahead with the first one or the simpler one? I looked at the imports and I think it's okay to go for a rename.

/assign

kranurag7 avatar Nov 30 '23 16:11 kranurag7

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Feb 28 '24 17:02 k8s-triage-robot