cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Implement MachinePool Machines clusterAPI proposal

Open cnmcavoy opened this issue 2 years ago • 10 comments
trafficstars

/kind feature

Describe the solution you'd like Provide an implementation for MachinePool Machines based off of this proposal.

AWSMachinePools & AWSManagedMachinePools should implement a status field for infrastructureMachineKind and infrastructureMachineSelector and manage these status fields in the controller reconcile loop. Each controller should spawn AWSMachine resources to represent EC2 instances managed by their external AWS autoscaling group resource. These AWSMachines need to have special handling in the AWSMachine reconciliation to skip any unnecessary steps for externally managed nodes.

Anything else you would like to add: See the clusterAPI implementation of their part of the proposal here: https://github.com/kubernetes-sigs/cluster-api/pull/7938

cnmcavoy avatar Mar 30 '23 22:03 cnmcavoy

/assign @cnmcavoy

cnmcavoy avatar Mar 30 '23 22:03 cnmcavoy

Do we think it is worth updating the docs in https://cluster-api-aws.sigs.k8s.io/topics/machinepools.html#autoscaling to reflect that in it's current state, you can't use the cluster-autoscaler clusterapi provider to scale MachinePools? It looks like this feature is required to be able to scale down properly.

com6056 avatar May 09 '23 16:05 com6056

/milestone v2.3.0 /triage accepted /priority important-soon

richardcase avatar Aug 16 '23 17:08 richardcase

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Jan 19 '24 04:01 k8s-triage-robot

/milestone clear

richardcase avatar Jan 23 '24 14:01 richardcase

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 22 '24 14:04 k8s-triage-robot

/remove-lifecycle stale

richardcase avatar Apr 22 '24 15:04 richardcase

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 21 '24 15:07 k8s-triage-robot

/remove-lifecycle stale /lifecycle frozen

richardcase avatar Jul 24 '24 17:07 richardcase