Garbage Collection is leaving behind Target Groups that are orphaned from Load Balancers

[voor]

trafficstars

/kind bug

What steps did you take and what happened:

• Create the cluster (EC2, not EKS), create a NLB inside the cluster:

   service.beta.kubernetes.io/aws-load-balancer-backend-protocol: tcp
   service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled: "true"
   service.beta.kubernetes.io/aws-load-balancer-type: nlb
  

• Delete the cluster but leave the NLB
• NLB is successfully deleted
• Target groups are not deleted and show has "Not Associated to any Load Balancer" in the AWS Console. (tags are still there for those target groups to show cluster ownership)
• Cluster hangs until target groups are removed
• Cluster immediately completes deleting with target groups are removed.

What did you expect to happen:

• Target groups with tags that associate them to a cluster are successfully removed.

Anything else you would like to add: Everything worked and required no intervention when the target groups were manually deleted from the AWS Console, unfortunately the logging didn't help debug this issue since this message was displayed each time:

"deleting aws resources created by tenant cluster"

Also:

"reconciling deletion for garbage collection" controller="awscluster" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="AWSCluster" aWSCluster="development-bob/tap-full-bob" namespace="development-bob" name="tap-full-bob" reconcileID=a9eca88a-ae24-411d-975a-6c163cbc3fe1 cluster="development-bob/tap-full-bob"
"deleting aws resources created by tenant cluster" controller="awscluster" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="AWSCluster" aWSCluster="development-bob/tap-full-bob" namespace="development-bob" name="tap-full-bob" reconcileID=a9eca88a-ae24-411d-975a-6c163cbc3fe1 cluster="development-bob/tap-full-bob"

Environment:

• Cluster-api-provider-aws version: v2.0.2
• Kubernetes version: (use kubectl version): v1.24.10
• OS (e.g. from /etc/os-release): Ubuntu 20.04

[Skarlso]

Does it also leave behind listeners? /triage accepted

[k8s-triage-robot]

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.