cluster-api-provider-aws
cluster-api-provider-aws copied to clipboard
PROPOSAL: Maintainers and reviewer changes
/hold
What type of PR is this? /kind support
What this PR does / why we need it:
Make the following changes to maintainers & reviewers:
- @Skarlso promoted to maintainer from reviewer
- @Ankitasw promoted to maintainer from reviewer
Let me or @sedefsavas know if you want to become a reviewer
This change will be on hold for approximately 1 week before its merged.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist:
- [ ] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
- [ ] adds or updates e2e tests
<3 <3 <3 <3
Massive thank you! :)
Lazy consensus until 19th October 2022
Very well deserved @Skarlso its always been a pleasure working with you.
Thank you, Ankita! I really appreciate your words. 😊😊😊❤️
Thank you for the proposal @richardcase. It has always been great working with CAPA and you folks 🙏
Just to echo what has been added in Slack for posterity against this change:
- @Ankitasw has been a consistent contributor of changes and reviews over the last year and has shown great commitment to the project, personally as a maintainer it has made my life easier, so thank you Ankita :pray:
- @Skarlso has made significant contributions in both reviews and new features (like ipv6) this year...thank you Gergely
You have both helped to push CAPA forward and i think as maintainers you will continue to make a significant impact and improvement on this project.
Thanks @Ankitasw and @Skarlso for all the commitment and great work to keep CAPA healthy!! 🙏
Very happy to see that CAPA is growing stronger with more maintainers.
@richardcase Thanks a lot for updating the Contributing guidelines so precisely 👏 This looks quite neat and helpful 😄
/lgtm Congrats!
Lazy consensus is up so:
/unhold /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: richardcase
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [richardcase]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment