cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

PROPOSAL: Maintainers and reviewer changes

Open richardcase opened this issue 3 years ago • 10 comments
trafficstars

/hold

What type of PR is this? /kind support

What this PR does / why we need it:

Make the following changes to maintainers & reviewers:

  • @Skarlso promoted to maintainer from reviewer
  • @Ankitasw promoted to maintainer from reviewer

Let me or @sedefsavas know if you want to become a reviewer

This change will be on hold for approximately 1 week before its merged.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

  • [ ] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests
  • [ ] adds or updates e2e tests

richardcase avatar Oct 12 '22 17:10 richardcase

<3 <3 <3 <3

Massive thank you! :)

Skarlso avatar Oct 12 '22 17:10 Skarlso

Lazy consensus until 19th October 2022

richardcase avatar Oct 12 '22 17:10 richardcase

Very well deserved @Skarlso its always been a pleasure working with you.

Ankitasw avatar Oct 13 '22 05:10 Ankitasw

Thank you, Ankita! I really appreciate your words. 😊😊😊❤️

Skarlso avatar Oct 13 '22 05:10 Skarlso

Thank you for the proposal @richardcase. It has always been great working with CAPA and you folks 🙏

Ankitasw avatar Oct 13 '22 07:10 Ankitasw

Just to echo what has been added in Slack for posterity against this change:

  • @Ankitasw has been a consistent contributor of changes and reviews over the last year and has shown great commitment to the project, personally as a maintainer it has made my life easier, so thank you Ankita :pray:
  • @Skarlso has made significant contributions in both reviews and new features (like ipv6) this year...thank you Gergely

You have both helped to push CAPA forward and i think as maintainers you will continue to make a significant impact and improvement on this project.

richardcase avatar Oct 13 '22 07:10 richardcase

Thanks @Ankitasw and @Skarlso for all the commitment and great work to keep CAPA healthy!! 🙏

Very happy to see that CAPA is growing stronger with more maintainers.

sedefsavas avatar Oct 13 '22 07:10 sedefsavas

@richardcase Thanks a lot for updating the Contributing guidelines so precisely 👏 This looks quite neat and helpful 😄

Ankitasw avatar Oct 13 '22 11:10 Ankitasw

/lgtm Congrats!

fabriziopandini avatar Oct 13 '22 12:10 fabriziopandini

Lazy consensus is up so:

/unhold /approve

richardcase avatar Oct 19 '22 09:10 richardcase

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 19 '22 09:10 k8s-ci-robot