cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Bump golangci-lint in /hack/tools and aws-iam-authenticator

Open Ankitasw opened this issue 3 years ago • 2 comments
trafficstars

What type of PR is this? /area release

What this PR does / why we need it: This PR bumps :

  • aws-iam-authenticator to v0.5.10
  • golangci-lint to v1.50.0 in /hack/tools

This PR also fixes lint and generate file errors.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

  • [ ] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests
  • [ ] adds or updates e2e tests

Ankitasw avatar Oct 12 '22 08:10 Ankitasw

@Skarlso next week onwards, i don't have to wait for approval post lgtm 😛

Ankitasw avatar Oct 13 '22 07:10 Ankitasw

/approve

Ankitasw avatar Oct 20 '22 08:10 Ankitasw

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 20 '22 08:10 k8s-ci-robot