cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Restructure e2e templates directory

Open Ankitasw opened this issue 3 years ago • 7 comments
trafficstars

What type of PR is this? /kind refactor

What this PR does / why we need it: This PR moves clusterclass definitions out of kustomized_sources directory.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

  • [x] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests
  • [x] adds or updates e2e tests

Ankitasw avatar Sep 27 '22 13:09 Ankitasw

/test pull-cluster-api-provider-aws-e2e /test pull-cluster-api-provider-aws-e2e-clusterclass

Ankitasw avatar Sep 27 '22 14:09 Ankitasw

cc @sedefsavas

Ankitasw avatar Sep 28 '22 14:09 Ankitasw

cc @richardcase

Ankitasw avatar Sep 30 '22 15:09 Ankitasw

Whats the context around this restructuring?

richardcase avatar Oct 10 '22 14:10 richardcase

I think few days back this PR was created, I just rebased and made changes. The context can be found in the PR itself.

Ankitasw avatar Oct 12 '22 07:10 Ankitasw

I think few days back this PR was created, I just rebased and made changes. The context can be found in the PR itself.

Thanks @Ankitasw . Adding the link to the slack conversation with the discussion.

richardcase avatar Oct 12 '22 14:10 richardcase

cc @Skarlso @richardcase if I can get 👀 for review?

Ankitasw avatar Oct 20 '22 08:10 Ankitasw

/test pull-cluster-api-provider-aws-e2e /test pull-cluster-api-provider-aws-e2e-clusterclass

Ankitasw avatar Oct 20 '22 15:10 Ankitasw

@Ankitasw: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test pull-cluster-api-provider-aws-e2e-clusterclas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 20 '22 15:10 k8s-ci-robot

@richardcase this PR is ready for review.

Ankitasw avatar Oct 24 '22 07:10 Ankitasw

cc @Skarlso @dlipovetsky if you folks could please review this ?

Ankitasw avatar Oct 25 '22 09:10 Ankitasw

Will do

Skarlso avatar Oct 25 '22 10:10 Skarlso

Thanks for making that change @Ankitasw . From my side:

/lgtm

richardcase avatar Oct 25 '22 11:10 richardcase

/approve

Skarlso avatar Oct 25 '22 12:10 Skarlso

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 25 '22 12:10 k8s-ci-robot

Thanks @richardcase @Skarlso 😄

Ankitasw avatar Oct 25 '22 12:10 Ankitasw