cluster-api-provider-aws
cluster-api-provider-aws copied to clipboard
Restructure e2e templates directory
What type of PR is this? /kind refactor
What this PR does / why we need it: This PR moves clusterclass definitions out of kustomized_sources directory.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist:
- [x] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
- [x] adds or updates e2e tests
/test pull-cluster-api-provider-aws-e2e /test pull-cluster-api-provider-aws-e2e-clusterclass
cc @sedefsavas
cc @richardcase
Whats the context around this restructuring?
I think few days back this PR was created, I just rebased and made changes. The context can be found in the PR itself.
I think few days back this PR was created, I just rebased and made changes. The context can be found in the PR itself.
Thanks @Ankitasw . Adding the link to the slack conversation with the discussion.
cc @Skarlso @richardcase if I can get 👀 for review?
/test pull-cluster-api-provider-aws-e2e /test pull-cluster-api-provider-aws-e2e-clusterclass
@Ankitasw: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test pull-cluster-api-provider-aws-build/test pull-cluster-api-provider-aws-test/test pull-cluster-api-provider-aws-verify
The following commands are available to trigger optional jobs:
/test pull-cluster-api-provider-aws-apidiff-main/test pull-cluster-api-provider-aws-e2e/test pull-cluster-api-provider-aws-e2e-blocking/test pull-cluster-api-provider-aws-e2e-clusterclass/test pull-cluster-api-provider-aws-e2e-conformance/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts/test pull-cluster-api-provider-aws-e2e-eks
Use /test all to run the following jobs that were automatically triggered:
pull-cluster-api-provider-aws-apidiff-mainpull-cluster-api-provider-aws-buildpull-cluster-api-provider-aws-testpull-cluster-api-provider-aws-verify
In response to this:
/test pull-cluster-api-provider-aws-e2e-clusterclas
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@richardcase this PR is ready for review.
cc @Skarlso @dlipovetsky if you folks could please review this ?
Will do
Thanks for making that change @Ankitasw . From my side:
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Skarlso
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Skarlso]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thanks @richardcase @Skarlso 😄