cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

switch to using interface func for consistency

Open luthermonson opened this issue 3 years ago • 10 comments
trafficstars

What type of PR is this? Not sure why the interface func wasn't on this line when it was used a few lines below. updating for consistency. /kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

  • [ ] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests
  • [ ] adds or updates e2e tests

luthermonson avatar Sep 13 '22 22:09 luthermonson

Hi @luthermonson. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 13 '22 22:09 k8s-ci-robot

/ok-to-test

Skarlso avatar Sep 14 '22 06:09 Skarlso

/hold until https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/3720 is merged. All upcoming PRs need to be merged once v1beta2 API types are in.

sedefsavas avatar Sep 14 '22 20:09 sedefsavas

/hold cancel

sedefsavas avatar Sep 22 '22 04:09 sedefsavas

/lgtm

Skarlso avatar Sep 23 '22 12:09 Skarlso

Thanks @luthermonson for the PR. Added a nit comment, else /lgtm

shivi28 avatar Oct 03 '22 05:10 shivi28

@shivi28 ready

luthermonson avatar Oct 03 '22 16:10 luthermonson

/lgtm

shivi28 avatar Oct 04 '22 02:10 shivi28

@shivi28 can this be merged?

luthermonson avatar Oct 14 '22 20:10 luthermonson

/lgtm /approve

shivi28 avatar Oct 17 '22 03:10 shivi28

/lgtm /approve

@shivi28 Huh, oddly, this didn't work. :O

Skarlso avatar Oct 18 '22 07:10 Skarlso

/lgtm /approve

Skarlso avatar Oct 19 '22 09:10 Skarlso

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shivi28, Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 19 '22 09:10 k8s-ci-robot