[wip] AMI Lookup Modifications

[luthermonson]

trafficstars

What type of PR is this? WIp for https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3663

/kind feature

What this PR does / why we need it:

• API Changes:
• Adds ImageLookupArch
• adds ImageLookupSSMParameterName
• Deprecates AMI.EKSOptimizedLookupType
• Adds ubuntu18.04/20.04, bottlerocket and preps Windows for EKS
• Enables Arm64 support
• Fixes logic error that you could be using EKS and set lookup BaseOS or Org and accidently pull a capa-ami image instead of an eks optimized.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

• [ ] squashed commits
• [ ] includes documentation
• [ ] adds unit tests
• [ ] adds or updates e2e tests

[k8s-ci-robot]

@luthermonson: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @luthermonson. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign cecilerobertmichon for approval by writing /assign @cecilerobertmichon in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[Skarlso]

Hello. Looks like you have some conversion issues or module clashes?

6:17:34 PM: # sigs.k8s.io/cluster-api-provider-aws/cmd/clusterawsadm/ami
6:17:34 PM: cmd/clusterawsadm/ami/copy.go:60:43: not enough arguments in call to "sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/services/ec2".DefaultAMILookup
6:17:34 PM: 	have (*"github.com/aws/aws-sdk-go/service/ec2".EC2, string, string, string, string)
6:17:34 PM: 	want (ec2iface.EC2API, string, string, string, string, string)

Also, would you mind signing your commits, please? :)

[luthermonson]

this is nowhere near done @Skarlso, i just did this to start the conversation on what I want to change. if there are no objections then ill proceed and turn it into a real PR

[Skarlso]

Ah gotcha. Thanks my bad. 😊👍

[Skarlso]

Adds ubuntu18.04/20.04, bottlerocket and preps Windows for EKS

Nice! We were actually looking at adding bottlerocket in #2009.

[Skarlso]

/ok-to-test

[k8s-ci-robot]

@luthermonson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-aws-verify	a573f0e3aca03e9a00252fa3581bdab73f3c2e3e	link	true	/test pull-cluster-api-provider-aws-verify
pull-cluster-api-provider-aws-apidiff-main	a573f0e3aca03e9a00252fa3581bdab73f3c2e3e	link	false	/test pull-cluster-api-provider-aws-apidiff-main
pull-cluster-api-provider-aws-test	a573f0e3aca03e9a00252fa3581bdab73f3c2e3e	link	true	/test pull-cluster-api-provider-aws-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

@luthermonson: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.