cluster-api-provider-aws
cluster-api-provider-aws copied to clipboard
kubernetes-sigs
Add multi-az test based on ClusterClass
What type of PR is this? /kind feature
What this PR does / why we need it: Add a multi-az test based on ClusterClass to verify CAPA is supporting CAPI's newly added ClusterClass feature.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #3346
Special notes for your reviewer:
Checklist:
- [ ] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
- [x] adds or updates e2e tests
@pydctw: This issue is currently awaiting triage.
If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign vincepri after the PR has been reviewed.
You can assign the PR to them by writing /assign @vincepri in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Investigated the test failure and filed an issue - https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3399
I've ran the tests multiple times locally and it passed except once, which had the same failure as the filed issue.
While the failure doesn't happen all the time, we will probably need to wait for the above issue to be resolved/fixed before merging this PR.
Test can pass but the cluster is affected by the continuous patching of subnets in AWSCluster by capi and capa controllers reported in https://github.com/kubernetes-sigs/cluster-api/issues/6320
@pydctw: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@pydctw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-provider-aws-e2e | c357f0fb71dca4e198eb9c8a8af2389be6138328 | link | false | /test pull-cluster-api-provider-aws-e2e |
| pull-cluster-api-provider-aws-build-release-1-5 | c357f0fb71dca4e198eb9c8a8af2389be6138328 | link | true | /test pull-cluster-api-provider-aws-build-release-1-5 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Closing as CAPA decided not to support this use case in v1beta2. This was a breaking change. ref: https://github.com/kubernetes-sigs/cluster-api-provider-aws/commit/39f088b79624c94e614cc6fedaf92284a3ddb686