cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Support looking up EKS optimized image for ARM

Open richardcase opened this issue 3 years ago • 7 comments
trafficstars

/kind bug

What steps did you take and what happened: When creating an EKS based cluster if we don't specify any of the image properties we [look up the default EKS optimized AMIs using SSM].

We only support looking up the base AL2 EKS ami and the GPU optimized AMI.

To support looking up EKS optimized images for ARM we need to use the following format when querying SSM:

/aws/service/eks/optimized-ami/%s/amazon-linux-2-arm64/recommended/image_id

This will require that we know we are using ARM based instances when looking up the images.

What did you expect to happen:

I would expect to be able to use EKS optimized ARM images without having to explicitly specify the image to look up.

Anything else you would like to add: Created as a result of a discussion on the community slack.

Environment:

  • Cluster-api-provider-aws version: 1.2.0
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

richardcase avatar Jan 31 '22 10:01 richardcase

/triage accepted /priority important-soon

richardcase avatar Jan 31 '22 10:01 richardcase

@richardcase Can you assign this to me? I will make a PR soon.

khoavo-hatch avatar Feb 11 '22 13:02 khoavo-hatch

Thank you @khoavo-hatch

/assign khoavo-hatch

richardcase avatar Feb 14 '22 13:02 richardcase

/lifecycle active

richardcase avatar Feb 14 '22 13:02 richardcase

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 15 '22 14:05 k8s-triage-robot

/remove-lifecycle stale #3208 is ready for review

khoavo-hatch avatar May 16 '22 05:05 khoavo-hatch

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 14 '22 06:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 13 '22 07:09 k8s-triage-robot

The issue has been marked as an important bug and triaged. Such issues are automatically marked as frozen when hitting the rotten state to avoid missing important bugs.

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle frozen

k8s-triage-robot avatar Sep 13 '22 10:09 k8s-triage-robot

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Feb 08 '23 01:02 k8s-triage-robot

/triage accepted

richardcase avatar Feb 08 '23 11:02 richardcase

Hey 👋, I noticed that the original PR for this went stale, and we're currently needing this feature. So, I decided to open a PR and rebase the changes from the original PR. I'm also happy to pick up this issue going forward!

charlie-haley avatar Feb 08 '23 17:02 charlie-haley

/assign charlie-haley

richardcase avatar Feb 08 '23 19:02 richardcase