cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

[WIP]Fetch ELB instance port from KCP's kubeconfig of cluster

Open Ankitasw opened this issue 3 years ago • 12 comments
trafficstars

What type of PR is this? /kind bug

What this PR does / why we need it: This PR removes the hardcoded ELB instance port value, and reads it's value from the KubeadmControlPlane kubeconfig's InitConfig BindPort, so as to keep the port information consistent throughout the cluster.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #2316

Checklist:

  • [x] squashed commits
  • [ ] includes documentation
  • [X] adds unit tests
  • [ ] adds or updates e2e tests

Release note:

Fetch ELB instance port from KCP kubeconfig's APIEndpoint

Ankitasw avatar Jan 06 '22 12:01 Ankitasw

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign sedefsavas after the PR has been reviewed. You can assign the PR to them by writing /assign @sedefsavas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 06 '22 12:01 k8s-ci-robot

/priority important-soon /triage accepted

Ankitasw avatar Jan 06 '22 12:01 Ankitasw

/retest

Ankitasw avatar Jan 06 '22 12:01 Ankitasw

/retest

Ankitasw avatar Jan 07 '22 11:01 Ankitasw

/test pull-cluster-api-provider-aws-e2e

Ankitasw avatar Jan 07 '22 11:01 Ankitasw

/test pull-cluster-api-provider-aws-e2e

Ankitasw avatar Jan 10 '22 07:01 Ankitasw

/retest

Ankitasw avatar Jan 10 '22 10:01 Ankitasw

/hold until discussions resolved.

sedefsavas avatar Jan 12 '22 20:01 sedefsavas

@Ankitasw: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 19 '22 11:01 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 05 '22 16:05 k8s-triage-robot

/remove-lifecycle stale

Ankitasw avatar May 06 '22 06:05 Ankitasw

@Ankitasw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-build-release-1-5 9a6df66fff32c97ef9cb37b7075d25af05421a66 link true /test pull-cluster-api-provider-aws-build-release-1-5

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jul 29 '22 12:07 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 27 '22 13:10 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Nov 26 '22 13:11 k8s-triage-robot

This has not been fixed in CAPI yet.

Ankitasw avatar Dec 02 '22 10:12 Ankitasw