cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Additional Tags do not reconcile on bastion

Open warroyo opened this issue 4 years ago • 15 comments
trafficstars

/kind bug

What steps did you take and what happened: when updating the AWSCluster.spec.additionalTags field tags are reconciled on all instances except for the bastion host.

What did you expect to happen: updating tags in the spec should also reconcile on the bastion host

Environment:

  • Cluster-api-provider-aws version: v0.6.4
  • Kubernetes version: (use kubectl version): v1.20.5
  • OS (e.g. from /etc/os-release): ubuntu-20.04

warroyo avatar Oct 11 '21 18:10 warroyo

/triage accepted /help

richardcase avatar Oct 13 '21 05:10 richardcase

@richardcase: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/triage accepted /help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 13 '21 05:10 k8s-ci-robot

/good-first-issue

sedefsavas avatar Oct 13 '21 21:10 sedefsavas

@sedefsavas: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 13 '21 21:10 k8s-ci-robot

/assign

amustaque97 avatar Oct 16 '21 19:10 amustaque97

:wave: @sedefsavas, I would love to work on this issue. Could you please share some pointers in order to fix this issue and how to reproduce/test locally?

amustaque97 avatar Oct 16 '21 19:10 amustaque97

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 14 '22 19:01 k8s-triage-robot

Are you still working on this @amustaque97? Otherwise feel free to unassign.

sedefsavas avatar Jan 19 '22 07:01 sedefsavas

/lifecycle frozen

sedefsavas avatar Jan 19 '22 07:01 sedefsavas

/remove-lifecycle frozen

richardcase avatar Jul 12 '22 16:07 richardcase

/assign

tasdikrahman avatar Aug 16 '22 05:08 tasdikrahman

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 14 '22 06:11 k8s-triage-robot

/assign

exitflynn avatar Jan 30 '23 19:01 exitflynn

@warroyo @sedefsavas Please let me know if this is still unresolved as I'd like to work on this

/assign

ashutosh887 avatar Apr 29 '23 02:04 ashutosh887

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Apr 28 '24 02:04 k8s-triage-robot