v1beta2 API Changes

[richardcase]

trafficstars

/kind refactor /kind api-change /area provider/eks /priority important-soon /milestone v0.7.0

Describe the solution you'd like Refactor the API with the proposed changes for v1beta2/v1 including any field deprecations:

Changes:

• [ ] EKS changes (old doc: https://docs.google.com/document/d/1EeD2KjFfeKoD-o0LJTMMWh9GUy-15yG80S5Uoj7oKcA/edit)
• [ ] Remove Equals from Tags
• [ ] ARN field in AWSResourceReference.
• [ ] AWSManagedMachinePool field deprecations as a result of #3094

Environment:

• Cluster-api-provider-aws version: 0.6.5

[richardcase]

/assign

[randomvariable]

/kind release-blocking

[richardcase]

As this requires a change in contract we will have to wait for the next API bump (i.e. v1alpha5)

/milestone Next /priority important-longterm

[richardcase]

/unassign

[sedefsavas]

/triage accepted

[randomvariable]

/milestone backlog

[k8s-ci-robot]

@randomvariable: The provided milestone is not valid for this repository. Milestones in this repository: [Backlog, v0.6.x, v0.7.0, v0.7.x, v1.0.x, v1.1.0, v1.x]

Use /milestone clear to clear the milestone.

In response to this:

/milestone backlog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[richardcase]

/lifecycle frozen

[richardcase]

Changing this to be a general v1beta2/v1 API changes issue

[Ankitasw]

ARN field in AWSResourceReference. (couldn't edit the PR description, not enough permissions)

[pydctw]

FailureDomain in AWSMachine.

From CAPI book

providers will be expected to remove the field in the next version that provides breaking API changes, favoring the value defined on Machine.Spec.FailureDomain instead.

[richardcase]

Refactor the disableVPCCNI on the managed control plane so that the disable and extra args are in a struct. So we'd have something like:

vpccni:
  disable: true

[richardcase]

Fix the typo in #3467

[sedefsavas]

Adding CCM tags to route tables and SGs: https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3532 https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3481

[richardcase]

Make sure we don't miss: #3526

[richardcase]

/remove-lifecycle frozen

[richardcase]

Change the addons override to default to overwrite: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/3513#discussion_r920090162

[pydctw]

Top-level issue for Adopting CAPI's Server Side Apply to support ClusterClass

• https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3530

Specific Issues that require v1beta2 API

• https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3528
• https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3536

[sedefsavas]

Remove deviceName from rootVolume in AWSMachinePool CR: https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3624

[sedefsavas]

NLB support: https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3088 with uniques NLB names: https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/969

[sedefsavas]

Internet-facing LB scheme clean up: https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/3673

[sedefsavas]

Move SSH key validation out of API types: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/3720#discussion_r972086935

[sedefsavas]

This might need API change as well: https://github.com/kubernetes-sigs/cluster-api/pull/6412 cc @dlipovetsky

[richardcase]

/milestone v2.0.0

[richardcase]

We need to review the items on this and see what we need to get in and what can be moved to v1beta3

[Ankitasw]

AWSManagedMachinePool field deprecations as a result of https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/3094 can be moved to next API version.

[Ankitasw]

/close

[k8s-ci-robot]

@Ankitasw: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.