cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Add expiration logic to the providers and sessions in the cache

Open sedefsavas opened this issue 4 years ago • 9 comments

Currently, we cache providers and sessions but we do not cleanup them from the cache. It would be good to have a mechanism to define an expiration on them and remove them when expired.

var sessionCache sync.Map
var providerCache sync.Map

/milestone v0.7.x

sedefsavas avatar Mar 31 '21 18:03 sedefsavas

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Jun 29 '21 19:06 fejta-bot

/lifecycle frozen

sedefsavas avatar Jul 01 '21 03:07 sedefsavas

/area performance /priority important-soon

randomvariable avatar Nov 08 '21 19:11 randomvariable

/assign

Ankitasw avatar Mar 13 '22 15:03 Ankitasw

@sedefsavas regarding time for expiration of cache, which component will decide that? Shall we hardcode it to some value?

Ankitasw avatar Mar 15 '22 14:03 Ankitasw

Rethinking: is this covered as part of API rate limiting?

Ankitasw avatar Mar 15 '22 15:03 Ankitasw

No, this is not related to SDK calls. We cache providers/sessions but do not clean them. For example, identities that are no longer in use will linger until CAPA controller is restarted.

sedefsavas avatar Mar 16 '22 19:03 sedefsavas

No, this is not related to SDK calls. We cache providers/sessions but do not clean them. For example, identities that are no longer in use will linger until CAPA controller is restarted.

Got it, so here comes the follow up question, regarding time for expiration of cache, which component will decide that? Shall we hardcode it to some value?

Ankitasw avatar Mar 17 '22 11:03 Ankitasw

/remove-lifecycle frozen

richardcase avatar Jul 12 '22 16:07 richardcase

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 24 '22 12:10 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Dec 10 '22 18:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Jan 09 '23 18:01 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 09 '23 18:01 k8s-ci-robot