cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Control Plane Load Balancer Attachments management from Machine

Open Danil-Grigorev opened this issue 4 years ago • 8 comments
trafficstars

/kind feature

Describe the solution you'd like

Currently, the AWSCluster resource allows specification of a single classic load balancer (in spec and status). This works well when the AWSCluster is being managed by the AWSCluster controller, however, with the introduction of the Externally Managed Cluster Infrastructure concept, this could present a limitation to external cluster infrastructure provisioners.

Other infrastructure provisioners may use other types of load balancers (eg Network Load Balancers) or may even use multiple load balancers (one for external traffic and one for internal traffic, for security reasons). With the current design of the AWSCluster resource, this cannot be supported by external provisioners who intend to use the AWSMachine controller to provision AWS infrastructure for Machines.

The following needs to be met to allow internal and external management of cluster infrastructure:

  • The AWSMachine controller must assume the load balancer attachment for control plane machines is optional (perhaps this is also done by some other component)
  • The AWSMachine controller should be able to attach multiple load balancers to a single machine
    • These load balancers may be of different types (eg Classic ELB and NLB)
  • The AWSCluster resource should be extended to allow many (or no) load balancers
    • In Spec and Status, there should be lists of load balancers rather than a single instance as is today
    • This should also allow for multiple types of load balancers as per the provisioner requirements

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

Danil-Grigorev avatar Mar 04 '21 17:03 Danil-Grigorev

cc @JoelSpeed Feel free to add details to this issue if I missed anything.

Danil-Grigorev avatar Mar 04 '21 17:03 Danil-Grigorev

This suggestion seems useful

alexander-demicev avatar Mar 04 '21 18:03 alexander-demicev

/assign

Danil-Grigorev avatar Mar 10 '21 16:03 Danil-Grigorev

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Jun 08 '21 16:06 fejta-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

k8s-triage-robot avatar Jul 28 '21 17:07 k8s-triage-robot

/lifecycle frozen

randomvariable avatar Jul 28 '21 19:07 randomvariable

/priority backlog

randomvariable avatar Nov 08 '21 18:11 randomvariable

/remove-lifecycle frozen

richardcase avatar Jul 12 '22 16:07 richardcase

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 23 '22 20:10 k8s-triage-robot

Most certainly not all aspects of this issue are addressed by this, but there currently is movement in using NLBs instead of classic load balancers for control-plane machines: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/3804. There seems to be a possibility to choose the type for the LB.

johannesfrey avatar Nov 02 '22 07:11 johannesfrey

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Dec 02 '22 08:12 k8s-triage-robot

The multiple load balancers (internal vs external) element here still seems important, do we want to track this still?

JoelSpeed avatar Dec 02 '22 09:12 JoelSpeed

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Jan 01 '23 09:01 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 01 '23 09:01 k8s-ci-robot