[e2e] Update EKS tests to use the `EKSControlPlaneUpdating` condition

[richardcase]

trafficstars

/kind feature /area provider/eks /area testing /help

Describe the solution you'd like The waitForControlPlaneToBeUpgraded should be updated to use the new EKSControlPlaneUpdating condition. Within the e2e test framework there is a function that allows you to wait based on a condition.

Anything else you would like to add: The EKSControlPlaneUpdating was introduced as part of #2246. Currently, the upgrade test is disabled in prow so this will need to be tested locally.

Environment:

• Cluster-api-provider-aws version: 0.6.4

[k8s-ci-robot]

@richardcase: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/kind feature /area provider/eks /area testing /help

Describe the solution you'd like The waitForControlPlaneToBeUpgraded should be updated to use the new EKSControlPlaneUpdating condition. Within the e2e test framework there is a function that allows you to wait based on a condition.

Anything else you would like to add: The EKSControlPlaneUpdating was introduced as part of #2246. Currently, the upgrade test is disabled in prow so this will need to be tested locally.

Environment:

• Cluster-api-provider-aws version: 0.6.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[richardcase]

Happy to help anyone if they want to pick this up.

[fejta-bot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

[richardcase]

/lifecycle frozen /good-first-issue

[k8s-ci-robot]

@richardcase: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/lifecycle frozen /good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[randomvariable]

/priority backlog

[DiptoChakrabarty]

@richardcase can this issue still be worked on , do we have to use the EKSControlPlaneUpdating condition within this case https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/18ba5a5968fcd6289f50994e3ffff856066c154d/test/e2e/suites/managed/control_plane_helpers.go#L58-L60

I would like to try it out

[richardcase]

@DiptoChakrabarty - there is some discussion on this in PR #3027

[richardcase]

/remove-lifecycle frozen

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[exitflynn]

/assign