cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Make controller IAM policies specific to each controller

Open MarcusNoble opened this issue 4 years ago • 16 comments
trafficstars

/kind feature

Describe the solution you'd like Currently the controllers use a single IAM policy (AWSIAMManagedPolicyControllers) to cover all their required actions. It would be good to split these out into more specific policies to avoid giving unnecessary permissions.

Anything else you would like to add: This would be useful to be able to provide an IAM role for the controllers to use (making use of Kiam or IRSA) - some changes would need to be made to support using different roles.

It would be good to also have a policy that can be generated to create a role in another account that can be assumed when #1919 (multitenancy) is available.

MarcusNoble avatar Dec 04 '20 11:12 MarcusNoble

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Mar 04 '21 11:03 fejta-bot

/remove-lifecycle stale

MarcusNoble avatar Mar 04 '21 13:03 MarcusNoble

/assign

randomvariable avatar Mar 11 '21 20:03 randomvariable

/milestone v0.7.0

richardcase avatar Mar 22 '21 17:03 richardcase

/unassign

randomvariable avatar Mar 23 '21 14:03 randomvariable

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Jun 21 '21 15:06 fejta-bot

/lifecycle frozen

richardcase avatar Jun 21 '21 15:06 richardcase

Do we still want to do this given we merged the controllers together?

randomvariable avatar Nov 08 '21 19:11 randomvariable

/triage cancel

randomvariable avatar Nov 08 '21 19:11 randomvariable

@randomvariable: The label(s) triage/cancel cannot be applied, because the repository doesn't have them.

In response to this:

/triage cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 08 '21 19:11 k8s-ci-robot

/untriage

randomvariable avatar Nov 08 '21 19:11 randomvariable

/triage ?

randomvariable avatar Nov 08 '21 19:11 randomvariable

@randomvariable: The label(s) triage/? cannot be applied, because the repository doesn't have them.

In response to this:

/triage ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 08 '21 19:11 k8s-ci-robot

/priority awaiting-more-evidence

randomvariable avatar Nov 08 '21 19:11 randomvariable

/remove triage

randomvariable avatar Nov 08 '21 19:11 randomvariable

/remove-lifecycle frozen

richardcase avatar Jul 12 '22 15:07 richardcase

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 23 '22 19:10 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Nov 22 '22 19:11 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Dec 22 '22 20:12 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 22 '22 20:12 k8s-ci-robot