cluster-api-ipam-provider-in-cluster icon indicating copy to clipboard operation
cluster-api-ipam-provider-in-cluster copied to clipboard

🐛 Fix image reference in tilt-provider.yaml

Open erwin-kok opened this issue 1 year ago • 5 comments

  • This is a small fix to be able to use tilt in other project referring to this project.

While testing cluster-api-proxmox (which has tilt reference to this project), I found that tilt was not able to build this provider. Digging into it I found that the image reference was changed from "telekom" to "k8s-staging-capi-ipam-ic". However, this reference was not updated. @schrej can you perhaps acknowledge that this is the correct fix?

erwin-kok avatar Aug 16 '24 08:08 erwin-kok

Welcome @erwin-kok!

It looks like this is your first PR to kubernetes-sigs/cluster-api-ipam-provider-in-cluster 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-ipam-provider-in-cluster has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 16 '24 08:08 k8s-ci-robot

It is. I had this changed locally already but apparently forgot to commit and push it as well...

You'll need to sign the CLA for me to be able to merge this. If you don't want to bother I can also fix it myself.

schrej avatar Aug 16 '24 13:08 schrej

It is. I had this changed locally already but apparently forgot to commit and push it as well...

You'll need to sign the CLA for me to be able to merge this. If you don't want to bother I can also fix it myself.

Thanks @schrej!

Please give me some time to sign the CLA (I was not aware of this). I don't want to get trouble with my employer (I want to contribute on a personal basis). I will come back to this asap.

erwin-kok avatar Aug 16 '24 13:08 erwin-kok

Hi @schrej , the CLA is covered now! Can you have another look?

erwin-kok avatar Aug 22 '24 17:08 erwin-kok

Thanks!

/lgtm /approve

schrej avatar Aug 22 '24 17:08 schrej

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erwin-kok, schrej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 22 '24 17:08 k8s-ci-robot