cloud-provider-azure icon indicating copy to clipboard operation
cloud-provider-azure copied to clipboard

VMSS Flex Support: Add a new vmType for pure VMSS Flex cluster to bypass the node type check

Open zmyzheng opened this issue 3 years ago • 4 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Currently, the CCM first checks the node type then chooses the correct VMSet implementation for the corresponding operation. It mantains a cache for the ndoe type and refreshes the cache by calling an Azure API every time the cache expires. In pure vmssflex node cluster, the node type check can be bypassed to reduce the API calls to Azure. image

Which issue(s) this PR fixes:

Fixes #639

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


zmyzheng avatar Oct 13 '22 20:10 zmyzheng

Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
Latest commit 4ebdb52b6957c2731eba4d1f9a02c5203b283384
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/63487a80af42e70008cffb7c

netlify[bot] avatar Oct 13 '22 20:10 netlify[bot]

Hi @zmyzheng. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 13 '22 20:10 k8s-ci-robot

Coverage Status

Coverage decreased (-0.01%) to 79.909% when pulling 4ebdb52b6957c2731eba4d1f9a02c5203b283384 on zmyzheng:vmssflex-vmtype into 8d0fb7ff4243b06d77bfb1e3d60317bc5c5f2f4e on kubernetes-sigs:master.

coveralls avatar Oct 13 '22 20:10 coveralls

/ok-to-test

andyzhangx avatar Oct 14 '22 08:10 andyzhangx

/retest

zmyzheng avatar Oct 14 '22 17:10 zmyzheng

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, zmyzheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 21 '22 05:10 k8s-ci-robot

/retest

zmyzheng avatar Oct 21 '22 07:10 zmyzheng

/retest

zmyzheng avatar Oct 21 '22 20:10 zmyzheng