cloud-provider-azure icon indicating copy to clipboard operation
cloud-provider-azure copied to clipboard

feat: switch azurefile snanshot to management api

Open umagnus opened this issue 3 years ago • 7 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: switch azurefile snanshot to management api

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


umagnus avatar Oct 09 '22 07:10 umagnus

Welcome @umagnus!

It looks like this is your first PR to kubernetes-sigs/cloud-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cloud-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Oct 09 '22 07:10 k8s-ci-robot

Hi @umagnus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 09 '22 07:10 k8s-ci-robot

Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
Latest commit ec4057a23fdc8c581731ae4fb3c7e1a17f97f3f4
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/63579cade5f4ff0009904684

netlify[bot] avatar Oct 09 '22 07:10 netlify[bot]

/ok-to-test

feiskyer avatar Oct 10 '22 07:10 feiskyer

Coverage Status

Coverage increased (+0.0009%) to 79.856% when pulling ec4057a23fdc8c581731ae4fb3c7e1a17f97f3f4 on umagnus:snapshot into ccc0413580ef069ea5712194923c0859ffc7581c on kubernetes-sigs:master.

coveralls avatar Oct 10 '22 07:10 coveralls

/retest

umagnus avatar Oct 17 '22 06:10 umagnus

/retest

umagnus avatar Oct 19 '22 02:10 umagnus

pls also change the PR title and add release notes, it's not switch, it's support snapshot with management api

andyzhangx avatar Oct 20 '22 08:10 andyzhangx

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, umagnus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 25 '22 13:10 k8s-ci-robot

/retest

andyzhangx avatar Oct 26 '22 00:10 andyzhangx