cloud-provider-azure icon indicating copy to clipboard operation
cloud-provider-azure copied to clipboard

VMSS Flex Support: FlexScaleSet implementation of VMSet: part 1

Open zmyzheng opened this issue 3 years ago • 14 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR is the first part of FlexScaleSet implementation of VMSet

Which issue(s) this PR fixes:

Refer to #639

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


zmyzheng avatar Aug 09 '22 22:08 zmyzheng

Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
Latest commit 700ad00caba0d2afa862abf6fc6fcfd06e880537
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/62fc581de8c8e1000bc09be6

netlify[bot] avatar Aug 09 '22 22:08 netlify[bot]

Hi @zmyzheng. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 09 '22 22:08 k8s-ci-robot

/ok-to-test

nilo19 avatar Aug 10 '22 02:08 nilo19

/retest

zmyzheng avatar Aug 10 '22 02:08 zmyzheng

/retest

zmyzheng avatar Aug 10 '22 04:08 zmyzheng

/retest

zmyzheng avatar Aug 10 '22 04:08 zmyzheng

/retest

zmyzheng avatar Aug 10 '22 05:08 zmyzheng

/retest

zmyzheng avatar Aug 10 '22 23:08 zmyzheng

/retest

zmyzheng avatar Aug 11 '22 01:08 zmyzheng

/azp run kubernetes-sigs.cloud-provider-azure.basic_lb

nilo19 avatar Aug 11 '22 03:08 nilo19

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 11 '22 03:08 azure-pipelines[bot]

/azp run kubernetes-sigs.cloud-provider-azure.basic_lb (run_basic_lb_e2e create_aks_cluster_and_run_tests_job)

nilo19 avatar Aug 11 '22 03:08 nilo19

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar Aug 11 '22 03:08 azure-pipelines[bot]

Coverage Status

Coverage increased (+0.05%) to 79.884% when pulling 700ad00caba0d2afa862abf6fc6fcfd06e880537 on zmyzheng:vmssflex-vmset into d9b89f161e76e240d275970c04666c27bb8f91a9 on kubernetes-sigs:master.

coveralls avatar Aug 17 '22 02:08 coveralls

/retest

zmyzheng avatar Aug 17 '22 04:08 zmyzheng

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, zmyzheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 17 '22 09:08 k8s-ci-robot

/retest

zmyzheng avatar Aug 17 '22 16:08 zmyzheng