IsLikelyNotMountPoint issue when upgrade k8s.io/mount-utils from v0.29.4 to v0.30.2

[andyzhangx]

What happened: need to find out whether it's ok to upgrade to k8s.io/mount-utils, what's the change and impact in vendor/k8s.io/mount-utils/mount_linux.go

I0712 03:39:30.760769   14023 driver.go:93] Enabling controller service capability: EXPAND_VOLUME
    nodeserver_test.go:1040: 
        	Error Trace:	/home/prow/go/src/sigs.k8s.io/azurefile-csi-driver/pkg/azurefile/nodeserver_test.go:1040
        	Error:      	Received unexpected error:
        	            	rpc error: code = Internal desc = Could not mount target ./target_test: not a directory
        	Test:       	TestNodePublishVolumeIdempotentMount
    nodeserver_test.go:1042: 
        	Error Trace:	/home/prow/go/src/sigs.k8s.io/azurefile-csi-driver/pkg/azurefile/nodeserver_test.go:1042
        	Error:      	Received unexpected error:
        	            	rpc error: code = Internal desc = Could not mount target ./target_test: not a directory
        	Test:       	TestNodePublishVolumeIdempotentMount
    nodeserver_test.go:1056: 
        	Error Trace:	/home/prow/go/src/sigs.k8s.io/azurefile-csi-driver/pkg/azurefile/nodeserver_test.go:1056
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestNodePublishVolumeIdempotentMount
--- FAIL: TestNodePublishVolumeIdempotentMount (0.01s)

https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1973/commits/986ddc93bbd4808942c65e1c568c2e60694821f6#diff-9d276589000ecf169e4bb915a05a8c339bcb5e6c09c3d7734f915eedc246a404

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

• CSI Driver version:
• Kubernetes version (use kubectl version):
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[andyzhangx]

/assign @cvvz

[andyzhangx]

duplicated to issue mentioned here: https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/2055#issuecomment-2295096420:

the reimplemented IsLikelyNotMountPoint func in mount-utils would make one unit test fail, current IsLikelyNotMountPoint would return error on an empty dir with not a directory, I think that's a bug, we need to fix it in upstream k8s main repo.

=== RUN   TestNodePublishVolumeIdempotentMount
I0817 02:55:14.201401   14208 driver.go:93] Enabling controller service capability: CREATE_DELETE_VOLUME
I0817 02:55:14.201441   14208 driver.go:93] Enabling controller service capability: EXPAND_VOLUME
    nodeserver_test.go:1040: 
        	Error Trace:	/home/prow/go/src/sigs.k8s.io/azurefile-csi-driver/pkg/azurefile/nodeserver_test.go:1040
        	Error:      	Received unexpected error:
        	            	rpc error: code = Internal desc = Could not mount target ./target_test: not a directory
        	Test:       	TestNodePublishVolumeIdempotentMount
    nodeserver_test.go:1042: 
        	Error Trace:	/home/prow/go/src/sigs.k8s.io/azurefile-csi-driver/pkg/azurefile/nodeserver_test.go:1042
        	Error:      	Received unexpected error:
        	            	rpc error: code = Internal desc = Could not mount target ./target_test: not a directory
        	Test:       	TestNodePublishVolumeIdempotentMount
    nodeserver_test.go:1056: 
        	Error Trace:	/home/prow/go/src/sigs.k8s.io/azurefile-csi-driver/pkg/azurefile/nodeserver_test.go:1056
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 0
        	Test:       	TestNodePublishVolumeIdempotentMount

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[andyzhangx]

fixed by https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/2158