azurefile-csi-driver icon indicating copy to clipboard operation
azurefile-csi-driver copied to clipboard

[feat] support management api for volume snapshot

Open umagnus opened this issue 3 years ago • 3 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

[feat] support management api for volume snapshot

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

[feat] support management api for volume snapshot

umagnus avatar Oct 25 '22 08:10 umagnus

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: umagnus Once this PR has been reviewed and has the lgtm label, please assign andyzhangx for approval by writing /assign @andyzhangx in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 25 '22 08:10 k8s-ci-robot

Hi @umagnus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 25 '22 08:10 k8s-ci-robot

/ok-to-test

andyzhangx avatar Oct 25 '22 11:10 andyzhangx

/test pull-azurefile-csi-driver-e2e

andyzhangx avatar Nov 08 '22 06:11 andyzhangx

/test pull-azurefile-csi-driver-e2e

andyzhangx avatar Nov 08 '22 09:11 andyzhangx

/test pull-azurefile-csi-driver-e2e

umagnus avatar Nov 09 '22 01:11 umagnus

@umagnus can you squash all commits into 2 commits: 1) vendor change 2) azure disk driver change ?

andyzhangx avatar Nov 09 '22 02:11 andyzhangx

/test pull-azurefile-csi-driver-sanity

andyzhangx avatar Nov 10 '22 11:11 andyzhangx

/retest

andyzhangx avatar Nov 11 '22 13:11 andyzhangx

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, umagnus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 13 '22 09:11 k8s-ci-robot