azuredisk-csi-driver
azuredisk-csi-driver copied to clipboard
kubernetes-sigs
feat: add ReservedDataDiskSlotNum to helm-chart
What type of PR is this?
/kind feature
What this PR does / why we need it:
The option is not available in the HelmChart, and the option is never given from the DriverOptiont struct to Driver struct.
Which issue(s) this PR fixes:
Fixes #2382
Special notes for your reviewer:
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: ClementLachaussee (bb9a4ffecaa13dfa4222f28ec13aa6c0b5191161)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @ClementLachaussee!
It looks like this is your first PR to kubernetes-sigs/azuredisk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/azuredisk-csi-driver has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @ClementLachaussee. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hey @andyzhangx ! Thanks for your quick review, I have modified as requested and taken the liberty to modify the comment.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andyzhangx, ClementLachaussee
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [andyzhangx]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@ClementLachaussee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-azuredisk-csi-driver-external-e2e-single-az | bb9a4ffecaa13dfa4222f28ec13aa6c0b5191161 | link | unknown | /test pull-azuredisk-csi-driver-external-e2e-single-az |
| pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess | bb9a4ffecaa13dfa4222f28ec13aa6c0b5191161 | link | unknown | /test pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess |
| pull-azuredisk-csi-driver-e2e-capz | bb9a4ffecaa13dfa4222f28ec13aa6c0b5191161 | link | unknown | /test pull-azuredisk-csi-driver-e2e-capz |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@andyzhangx do you know when this can be added to a release ?
@ClementLachaussee I am adding this chart config into v1.29.7 release since it does not have that ReservedDataDiskSlotNum assign bug: https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2395