[WIP]feat: support PremiumV2_LRS disk type

[andyzhangx]

What type of PR is this? /kind feature

What this PR does / why we need it: feat: support PremiumV2_LRS disk type https://docs.microsoft.com/en-us/azure/virtual-machines/disks-deploy-premium-v2

Which issue(s) this PR fixes:

Fixes #

Requirements:

• [ ] uses conventional commit messages
• [ ] includes documentation
• [ ] adds unit tests
• [ ] tested upgrade from previous version

Special notes for your reviewer: need to register this feature first, otherwise would get following error:

  Warning  ProvisioningFailed    0s (x3 over 4s)        disk.csi.azure.com_aks-agentpool-31052490-vmss000000_d44e69ed-5e3f-4003-ae60-407285f787cf  failed to provision volume with StorageClass "managed-csi-v2": rpc error: code = Internal desc = Retriable: false, RetryAfter: 0s, HTTPStatusCode: 400, RawError: {
  "error": {
    "code": "InvalidParameter",
    "message": "SKU PremiumV2_LRS is not supported for resource type Disk in this region. Supported SKUs for this region are Premium_LRS,StandardSSD_LRS,Standard_LRS,UltraSSD_LRS",
    "target": "sku"
  }
}

Release note:

feat: support PremiumV2_LRS disk type

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[jmclong]

Good idea with the workaround for the enum. Can you please integration some of the changes here to this PR? Or, I can do so if you want. I did not realize that you were working on this as well, so it would be great if we could combine efforts here.

https://github.com/jmclong/azuredisk-csi-driver/commit/aaa495a05412c47617e275779bdf09cc0e5c563d#diff-e8145a1494aff30a14f33802e783782a5d59657f545b0bfffb13c445b4dd5235

[andyzhangx]

Good idea with the workaround for the enum. Can you please integration some of the changes here to this PR? Or, I can do so if you want:

jmclong@aaa495a#diff-e8145a1494aff30a14f33802e783782a5d59657f545b0bfffb13c445b4dd5235

Hi @jmclong , this is an incomplete PR since it touches vendor file change. Do you know how to whitelist some subscriptions to register PremiumV2 disk feature, I think this PR should work while still needs some verification, and add e2e test in the end when this feature rolled out to public regions.

[andyzhangx]

Good idea with the workaround for the enum. Can you please integration some of the changes here to this PR? Or, I can do so if you want: jmclong@aaa495a#diff-e8145a1494aff30a14f33802e783782a5d59657f545b0bfffb13c445b4dd5235

Hi @jmclong , this is an incomplete PR since it touches vendor file change. Do you know how to whitelist some subscriptions to register PremiumV2 disk feature, I think this PR should work while still needs some verification, and add e2e test in the end when this feature rolled out to public regions.

@jmclong btw, since this PremiumV2 disk feature is just available on a few limited regions, it's better not mention that in every example storage class, we may just mention this preview feature in storage class parameters in current stage.

[jmclong]

Good idea with the workaround for the enum. Can you please integration some of the changes here to this PR? Or, I can do so if you want: jmclong@aaa495a#diff-e8145a1494aff30a14f33802e783782a5d59657f545b0bfffb13c445b4dd5235

Hi @jmclong , this is an incomplete PR since it touches vendor file change. Do you know how to whitelist some subscriptions to register PremiumV2 disk feature, I think this PR should work while still needs some verification, and add e2e test in the end when this feature rolled out to public regions.

You can pull in changes from my branch: https://github.com/jmclong/azuredisk-csi-driver/commit/cfecf7c55bee3eb753d2c4a8cf9d5379ee784942

I added code to check if SKU is supported for the location and skip it otherwise. I think we will need the rest of these changes to cloud-provider-azure and the disk driver as well to support PremiumV2.

[jmclong]

I've integrated in your workaround for the SKU enum in my repo here, and I've qualified it with the e2e test in the repo here: https://github.com/jmclong/azuredisk-csi-driver/tree/premium-v2

[andyzhangx]

/retest