aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

Make it possible to provide a custom issuer for the certificate in the Helm chart

Open bianchi2 opened this issue 5 months ago • 8 comments

Description

It's a common practice to use one common issuer for all apps requiring certificates in a single cluster. This PR adds an optional certManager.existingIssuerName to values. When undefined, nothing changes and Issuer is created and referenced in the Certificate. When defined, no Issuer is created and a custom Issuer is referenced in the Certificate.

Checklist

  • [ ] Added tests that cover your change (if possible)
  • [ ] Added/modified documentation as required (such as the README.md, or the docs directory)
  • [x] Manually tested
  • [x] Made sure the title of the PR is a good description that can go into the release notes

bianchi2 avatar Jul 02 '25 21:07 bianchi2

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: bianchi2 / name: yivan-atl (887ca0230a4654746155d3e359dad0a01a21d2a1, 2f77ec179ee63cacc9b390f4e6f0e2467cb64ebd)

Hi @bianchi2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 02 '25 21:07 k8s-ci-robot

Is there any chance this PR gets a review? Thanks

bianchi2 avatar Aug 06 '25 09:08 bianchi2

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bianchi2, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 13 '25 05:08 k8s-ci-robot

/lgtm /approved

Thanks for the addition! Sorry about the delay.

zac-nixon avatar Aug 13 '25 05:08 zac-nixon

@zac-nixon thanks for approving it! What need to be done to be able to merge this PR? I saw a failing golint job - so I merged the latest main to my forked branch.

bianchi2 avatar Aug 13 '25 06:08 bianchi2

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Aug 13 '25 07:08 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 21 '25 06:10 k8s-ci-robot