aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Add `wafv2AclArn` field to IngressClassParams

Open mikutas opened this issue 1 year ago • 7 comments

Issue

part of #2311

Description

Add wafv2AclArn field to IngressClassParams.

  • The field is optional.
  • When the field is absent or empty, the controller behave as same as wafv2-acl-arn annotation.
  • When different arns are set between params and annotations, the error occurs as same as when different arns are set between multiple annotations.

Checklist

  • [x] Added tests that cover your change (if possible)
  • [x] Added/modified documentation as required (such as the README.md, or the docs directory)
  • [x] Manually tested
  • [x] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

  • [ ] Backfilled missing tests for code in same general area :tada:
  • [ ] Refactored something and made the world a better place :star2:

mikutas avatar Nov 28 '24 13:11 mikutas

Hi @mikutas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Nov 28 '24 13:11 k8s-ci-robot

/ok-to-test

zac-nixon avatar Jan 24 '25 19:01 zac-nixon

/lgtm

zac-nixon avatar Jan 24 '25 19:01 zac-nixon

rebased

mikutas avatar Apr 25 '25 03:04 mikutas

resolved conflicts

mikutas avatar May 27 '25 07:05 mikutas

@zac-nixon maybe it would be a good idea to release this together with https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/4290 as this PR has been stale for a few months

1ms-ms avatar Aug 05 '25 18:08 1ms-ms

resolved conflicts

mikutas avatar Aug 08 '25 01:08 mikutas

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikutas, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 08 '25 19:08 k8s-ci-robot

Thanks for the contribution!

zac-nixon avatar Aug 08 '25 19:08 zac-nixon

Huh, not sure why the bot didn't merge this a while ago. Sorry about that.

zac-nixon avatar Aug 13 '25 05:08 zac-nixon