TargetGroupBinding now support targetGroupName - #2655 refresh

[fatmcgav]

Issue

Partially solves https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/2373 #3586 #3819

Description

This PR contains the changes from #2655 rebased against the latest main and updated to support aws-sdk-go-v2.

All credit goes to @marcosdiez for the original PR and changes.

Checklist

• [x] Added tests that cover your change (if possible)
• [x] Added/modified documentation as required (such as the README.md, or the docs directory)
• [ ] Manually tested
• [ ] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

• [ ] Backfilled missing tests for code in same general area :tada:
• [ ] Refactored something and made the world a better place :star2:

[k8s-ci-robot]

Welcome @fatmcgav!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: marcosdiez / name: Marcos Diez (305e2a1f0381ae58a413d37ba66f9c914b549284, 6df756dacf7b53d6d73e83b3ce67c69b99c792ce, af53e2f15dce88912a1c524f5c28dd5e9587aa05, 4e278ca89e6420422907a78a45a12ded6242acb3, 87f03b56e54423bad45c2728711d629c17ac0338)
• :white_check_mark: login: fatmcgav / name: Gavin Williams (c973674e4e74aa1778235c3579c311c48a2e2497, 6cccbcbd6ea5fddfb5d87f356611034cadfe8377, b5ef7c919b42d59e7a6662ef109916d84a15669e, a70b5800fab239dc0d2e9208b3bdd41bb1cc0f7a)

[k8s-ci-robot]

Hi @fatmcgav. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fatmcgav]

cc @johngmyers As you reviewed the previous PR 👍

[shraddhabang]

/ok-to-test

[fatmcgav]

/ok-to-test

Hey @shraddhabang ... Thanks for ok'ing... I think you missed the last t though ;)

[fatmcgav]

Hey @shraddhabang

Thanks for running the tests. I'm glad they all passed :) Hopefully someone can review this soon and assuming all good then get it merged and released 🤞

[wweiwei-li]

/lgtm

[fatmcgav]

Thanks for the lgtm @wweiwei-li ... What's next to get this merged and released?

[fatmcgav]

I note that https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/3853/ has recently been merged and released.

I suspect this feature will further enhance and simplify the multi-cluster capabilities :)

[fatmcgav]

@shraddhabang / @wweiwei-li Nudge on this one ❤️

[MarcusDunn]

@shraddhabang / @wweiwei-li could you take a look at this / what it would take to get it merged? This change would be a huge QoL improvement for our deployments.

[fatmcgav]

@shraddhabang / @wweiwei-li I've rebased this branch from master, so please can we get this re-approved, merged and released :) ❤️

[shraddhabang]

/lgtm /approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fatmcgav, shraddhabang, zac-nixon Once this PR has been reviewed and has the lgtm label, please assign oliviassss for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[fatmcgav]

🥳 Thanks @shraddhabang

[fatmcgav]

@shraddhabang Are you able to confirm when the next release is scheduled for? 👍