aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

feat: make LeaseDuration configurable via `--leader-election-lease-duration` flag

Open gjbravi opened this issue 1 year ago • 12 comments

Issue

resolves https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/3823

Description

This PR adds a new flag to the controller, --leader-election-lease-duration will be responsible for externalizing and controlling the LeaseDuration of a Lease owned by aws-load-balancer-controller.

--leader-election-lease-duration defaults to 15s if not informed, matching the default value of a LeaseDuration from controller-runtime.

Checklist

  • [ ] Added tests that cover your change (if possible)
  • [x] Added/modified documentation as required (such as the README.md, or the docs directory)
  • [x] Manually tested
  • [x] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

  • [ ] Backfilled missing tests for code in same general area :tada:
  • [ ] Refactored something and made the world a better place :star2:

gjbravi avatar Sep 03 '24 17:09 gjbravi