aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

Add OIDC configuration auto discovery support

Open omerap12 opened this issue 1 year ago • 2 comments

Issue

#2921

Description

Introduced new functionality to alb.ingress.kubernetes.io/auth-idp-oidc annotation, support for OIDC configuration using discoveryEndpoint to fetch OIDC details dynamically. Enhanced documentation with instructions and example for using discoveryEndpoint in OIDC configuration. Created unit tests to validate the implementation and functionality of OIDC Discovery feature.

Checklist

  • [x] Added tests that cover your change (if possible)
  • [x] Added/modified documentation as required (such as the README.md, or the docs directory)
  • [ ] Manually tested
  • [x] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

  • [ ] Backfilled missing tests for code in same general area :tada:
  • [ ] Refactored something and made the world a better place :star2:

omerap12 avatar Jun 15 '24 16:06 omerap12

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12 Once this PR has been reviewed and has the lgtm label, please assign johngmyers for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 15 '24 16:06 k8s-ci-robot

Codecov Report

Attention: Patch coverage is 43.75000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 18.23%. Comparing base (e5d625f) to head (9621e73).

Files Patch % Lines
pkg/networking/utils.go 0.00% 16 Missing :warning:
pkg/ingress/auth_config_builder.go 87.50% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3747      +/-   ##
==========================================
+ Coverage   18.20%   18.23%   +0.02%     
==========================================
  Files         175      175              
  Lines       29280    29312      +32     
==========================================
+ Hits         5330     5344      +14     
- Misses      23584    23601      +17     
- Partials      366      367       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 15 '24 16:06 codecov-commenter

/ok-to-test

shraddhabang avatar Jul 25 '24 18:07 shraddhabang

/lgtm

shraddhabang avatar Jul 25 '24 18:07 shraddhabang

@omerap12, thanks for the contribution, overall lgtm. can you please add the manual test in your PR description? Thanks/

oliviassss avatar Aug 08 '24 23:08 oliviassss

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Aug 09 '24 14:08 k8s-ci-robot

@omerap12, thanks for the contribution, overall lgtm. can you please add the manual test in your PR description? Thanks/

Done :)

omerap12 avatar Aug 09 '24 14:08 omerap12

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 24 '24 23:09 k8s-ci-robot

@oliviassss , should I close this?

omerap12 avatar Sep 25 '24 03:09 omerap12