aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

[Feature Request] Add Ingress/Service object annotations to support recently added HTTP client keepalive duration

Open kswift opened this issue 1 year ago • 9 comments

Is your feature request related to a problem? Elastic Load Balancing team recently released HTTP client keepalive duration which can be configured for ALBs -> https://aws.amazon.com/about-aws/whats-new/2024/03/application-load-balancer-http-keepalive-duration/

This keepalive value specifies the maximum amount of time that ALB will maintain an HTTP connection with a client before closing the connection.

Describe the solution you'd like Specify this duration value via Ingress/Service object annotations.

Describe alternatives you've considered Configuring manually via awscli or console in meantime.

kswift avatar Apr 29 '24 21:04 kswift

/assign ChuksGrinage

shraddhabang avatar Apr 30 '24 22:04 shraddhabang

@shraddhabang: GitHub didn't allow me to assign the following users: ChuksGrinage.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign ChuksGrinage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 30 '24 22:04 k8s-ci-robot

Hey @shraddhabang , are you sure that's documentation issue?

omerap12 avatar May 05 '24 17:05 omerap12

/assign

omerap12 avatar May 06 '24 03:05 omerap12

From what I understand, annotations are just a key/value pairing of the options available to the ALB. And seeing that KAT is a fairly recent addition we can see how our annotation list would be out of date.

ChuksGrinage avatar May 06 '24 14:05 ChuksGrinage

We can confirm that you can set client keepalive time (KAT) by simply including annotation: For example: alb.ingress.kubernetes.io/load-balancer-attributes: client_keep_alive.seconds=3600

We are working to update the docs for future references

ChuksGrinage avatar May 08 '24 15:05 ChuksGrinage

@ChuksGrinage so nothing is needed for me then?

omerap12 avatar May 08 '24 15:05 omerap12

@omerap12 Yes, no action is needed. Thank you!

ChuksGrinage avatar May 08 '24 15:05 ChuksGrinage

/assign

ChuksGrinage avatar May 08 '24 17:05 ChuksGrinage