aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

feat: disable default helm labels

Open darkweaver87 opened this issue 1 year ago • 5 comments

Description

While many people might use this chart to install aws load balancer on their K8S with helm, some others might want to use this chart to only generate their yaml files with helm template and let CD solutions (ArgoCD, FluxCD, etc) deploy it. Thus, this PR let this people remove helm default labels in order to add, for instance, their own app.kubernetes.io/managed-by one. Inspired by https://github.com/cert-manager/cert-manager/blob/master/deploy/charts/cert-manager/templates/_helpers.tpl#L155.

Checklist

  • [ ] Added tests that cover your change (if possible)
  • [x] Added/modified documentation as required (such as the README.md, or the docs directory)
  • [x] Manually tested
  • [x] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

  • [ ] Backfilled missing tests for code in same general area :tada:
  • [ ] Refactored something and made the world a better place :star2:

darkweaver87 avatar Feb 13 '24 13:02 darkweaver87

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: darkweaver87 / name: Rémi BUISSON (15135d4cd4c2ee53d7883c0785578b82cfe84563, 2484205e8db055b76143ee64eb41b9a0d24fcc22)

Welcome @darkweaver87!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Feb 13 '24 13:02 k8s-ci-robot

Hi @darkweaver87. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 13 '24 13:02 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: darkweaver87 Once this PR has been reviewed and has the lgtm label, please assign m00nf1sh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 13 '24 13:02 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 02 '24 11:05 k8s-ci-robot

/ok-to-test @darkweaver87, sorry for the delay, this change lgtm, can you rebase the main? also please put the manual test you've done in the PR description. Thanks

oliviassss avatar May 21 '24 22:05 oliviassss

Thanks @oliviassss, rebase done :-)

darkweaver87 avatar May 22 '24 07:05 darkweaver87

/lgtm /approve

oliviassss avatar May 22 '24 16:05 oliviassss

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darkweaver87, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 22 '24 16:05 k8s-ci-robot