aws-load-balancer-controller
aws-load-balancer-controller copied to clipboard
update prow script and e2e test
Issue
Description
- Updated prow script for internal CI jobs running in isolated regions
- added the cleanup step in multi_path_backend_test in AfterEach()
- Add test coverage for internal ALB/NLB
Checklist
- [ ] Added tests that cover your change (if possible)
- [ ] Added/modified documentation as required (such as the
README.md, or thedocsdirectory) - [ ] Manually tested
- [ ] Made sure the title of the PR is a good description that can go into the release notes
BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:
- [ ] Backfilled missing tests for code in same general area :tada:
- [ ] Refactored something and made the world a better place :star2:
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2765407) 55.75% compared to head (37665aa) 55.75%.
Additional details and impacted files
@@ Coverage Diff @@
## main #3456 +/- ##
=======================================
Coverage 55.75% 55.75%
=======================================
Files 149 149
Lines 8843 8843
=======================================
Hits 4930 4930
Misses 3579 3579
Partials 334 334
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/retest
all the ingress and service tests cases passed, no error in the controller logs. but the job failed in the end with the error message
Error: deadline surpassed waiting for AWS load balancers to be deleted: k8s-e2egroupafac4b78-3b654f1c2d
+ echo 'unable to delete cluster lb-controller-e2e-3456-1724866415791443968'
unable to delete cluster lb-controller-e2e-3456-1724866415791443968
+ return 1
+ echo 'unable to delete cluster lb-controller-e2e-3456-1724866415791443968'
unable to delete cluster lb-controller-e2e-3456-1724866415791443968
+ return 1
make: *** [Makefile:197: e2e-test] Error 1
Need to reach out to the test account owners to take a further look from here.
Issue opened in kubernetes/k8s.io: https://github.com/kubernetes/k8s.io/issues/6086
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: M00nF1sh, oliviassss
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [M00nF1sh]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
New changes are detected. LGTM label has been removed.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale