aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

update prow script and e2e test

Open oliviassss opened this issue 2 years ago • 9 comments

Issue

Description

  1. Updated prow script for internal CI jobs running in isolated regions
  2. added the cleanup step in multi_path_backend_test in AfterEach()
  3. Add test coverage for internal ALB/NLB

Checklist

  • [ ] Added tests that cover your change (if possible)
  • [ ] Added/modified documentation as required (such as the README.md, or the docs directory)
  • [ ] Manually tested
  • [ ] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

  • [ ] Backfilled missing tests for code in same general area :tada:
  • [ ] Refactored something and made the world a better place :star2:

oliviassss avatar Oct 27 '23 21:10 oliviassss

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2765407) 55.75% compared to head (37665aa) 55.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3456   +/-   ##
=======================================
  Coverage   55.75%   55.75%           
=======================================
  Files         149      149           
  Lines        8843     8843           
=======================================
  Hits         4930     4930           
  Misses       3579     3579           
  Partials      334      334           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 27 '23 21:10 codecov-commenter

/retest

oliviassss avatar Nov 14 '23 21:11 oliviassss

all the ingress and service tests cases passed, no error in the controller logs. but the job failed in the end with the error message

Error: deadline surpassed waiting for AWS load balancers to be deleted: k8s-e2egroupafac4b78-3b654f1c2d
+ echo 'unable to delete cluster lb-controller-e2e-3456-1724866415791443968'
unable to delete cluster lb-controller-e2e-3456-1724866415791443968
+ return 1
+ echo 'unable to delete cluster lb-controller-e2e-3456-1724866415791443968'
unable to delete cluster lb-controller-e2e-3456-1724866415791443968
+ return 1
make: *** [Makefile:197: e2e-test] Error 1 

Need to reach out to the test account owners to take a further look from here.

oliviassss avatar Nov 15 '23 21:11 oliviassss

Issue opened in kubernetes/k8s.io: https://github.com/kubernetes/k8s.io/issues/6086

oliviassss avatar Nov 15 '23 22:11 oliviassss

/retest

oliviassss avatar Nov 16 '23 17:11 oliviassss

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 12 '23 00:12 k8s-ci-robot

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Dec 12 '23 01:12 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 18 '23 23:12 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 25 '24 20:04 k8s-triage-robot