aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

feat: add default ingressclass annotation ✨

Open meysam81 opened this issue 3 years ago • 3 comments

Issue

A replacement for aws/eks-charts#792

Description

Any ingressclass out there has the option to be the default ingressclass if the right value is passed to the chart. This is the reason behind this PR so that with passing a single value, we can have the ingressclass as the default inside the cluster.

Checklist

  • [ ] Added tests that cover your change (if possible)
  • [x] Added/modified documentation as required (such as the README.md, or the docs directory)
  • [x] Manually tested
  • [x] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

  • [ ] Backfilled missing tests for code in same general area :tada:
  • [ ] Refactored something and made the world a better place :star2:

meysam81 avatar Aug 10 '22 03:08 meysam81

Welcome @meysam81!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 10 '22 03:08 k8s-ci-robot

Hi @meysam81. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 10 '22 03:08 k8s-ci-robot

@M00nF1sh @kishorj @oliviassss @johngmyers

meysam81 avatar Aug 27 '22 01:08 meysam81

@kishorj done ✅

meysam81 avatar Sep 07 '22 02:09 meysam81

/ok-to-test

kishorj avatar Sep 07 '22 17:09 kishorj

Codecov Report

Base: 54.04% // Head: 54.03% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (482b8f6) compared to base (0d91884). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2756      +/-   ##
==========================================
- Coverage   54.04%   54.03%   -0.02%     
==========================================
  Files         144      144              
  Lines        8223     8225       +2     
==========================================
  Hits         4444     4444              
- Misses       3461     3463       +2     
  Partials      318      318              
Impacted Files Coverage Δ
pkg/deploy/elbv2/load_balancer_synthesizer.go 40.90% <0.00%> (-0.96%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 07 '22 17:09 codecov-commenter

/lgtm

kishorj avatar Sep 08 '22 16:09 kishorj

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, meysam81

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 08 '22 16:09 k8s-ci-robot